Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow default_tags to be set by environment variables #33339

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Allow default_tags to be set by environment variables #33339

merged 3 commits into from
Aug 2, 2024

Conversation

jtdoepke
Copy link
Contributor

@jtdoepke jtdoepke commented Sep 7, 2023 •
edited
Loading

Description

This commit has the provider consume default_tags from environment variables with the form TF_AWS_DEFAULT_TAGS_<tag_name>=<tag_value>. If the same tag is defined in both an environment variable and the Terraform config, the Terraform takes precedence.

Relations

Closes #33255

References

Output from Acceptance Testing

% make testacc TESTS=TestAccProvider_DefaultTagsTags_env_vars PKG_NAME=internal/provider

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/provider/... -v -count 1 -parallel 20 -run='TestAccProvider_DefaultTagsTags_env_vars'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider        [no test files]
=== RUN   TestAccProvider_DefaultTagsTags_env_vars
--- PASS: TestAccProvider_DefaultTagsTags_env_vars (20.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/provider   20.660s

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. and removed size/L Managed by automation to categorize the size of a PR. labels Sep 7, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 7, 2023
@jtdoepke jtdoepke force-pushed the f-default_tags-env-vars branch 2 times, most recently from 14e2a3e to 033814f Compare September 7, 2023 04:56
github-actions[bot]
github-actions bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jtdoepke 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. labels Sep 7, 2023
@jtdoepke jtdoepke changed the title [WIP] Allow default_tags to be set by environment variables Allow default_tags to be set by environment variables Sep 7, 2023
@jtdoepke jtdoepke mentioned this pull request Sep 7, 2023
Closed
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 7, 2023
@bcbrockway
Copy link

Just wondering what's left to get this over the line? We could really use this functionality.

@jtdoepke
provider: allow default_tags to be set by environment variables
d92e0e0 
This commit has the provider consume default_tags from environment
variables with the form `TF_AWS_DEFAULT_TAGS_<tag_name>=<tag_value>`. If
the same tag is defined in both an environment variable and the
Terraform config, the Terraform takes precedence.
@jar-b jar-b self-assigned this Aug 2, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 2, 2024
@jar-b jar-b requested a review from a team as a code owner August 2, 2024 19:32
@jar-b jar-b mentioned this pull request Aug 2, 2024
Merged
jar-b
jar-b approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b
Copy link
Member

jar-b commented Aug 2, 2024

Thanks for your contribution, @jtdoepke! 👍

@jar-b jar-b merged commit f94b2eb into hashicorp:main Aug 2, 2024
38 checks passed
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 2, 2024
@nitrocode nitrocode mentioned this pull request Aug 9, 2024
Closed
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nitrocode nitrocode mentioned this pull request Aug 12, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@brandon-berg brandon-berg brandon-berg left review comments

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.62.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: default_tags from environment variables
5 participants
@jtdoepke @bcbrockway @jar-b @brandon-berg @justinretzolk